Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JwtBearerTokenFlow.java #1346

Merged
merged 6 commits into from
Nov 15, 2023
Merged

Update JwtBearerTokenFlow.java #1346

merged 6 commits into from
Nov 15, 2023

Conversation

borisovkalin
Copy link
Contributor

Added additional setter for an opaque token responses.

Added additional setter for an opaque token responses.

Signed-off-by: Kalin Borisov <[email protected]>
Copy link

cla-assistant bot commented Nov 8, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@finkmanAtSap finkmanAtSap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Kalin, thanks for your contribution.

Can you please make the following changes?

Thanks!
Manuel

Copy link
Contributor

@finkmanAtSap finkmanAtSap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your changes. Looks very good. Just one small thing. Then I would like to merge it:
Can you please add one more assertion to the unit test that by default (if setOpaqueTokenFormat was not called yet), it does not contain the token_format key = opaque entry?
And likewise, at the end of the method, add the same assertion after calling setOpaqueTokenFormat(false) after having called setOpaqueTokenFormat(true) before?

Copy link
Contributor

@finkmanAtSap finkmanAtSap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you for the adjustments!

@finkmanAtSap finkmanAtSap merged commit 911aef5 into SAP:main Nov 15, 2023
5 checks passed
borisovkalin added a commit to borisovkalin/cloud-security-services-integration-library that referenced this pull request Nov 27, 2023
JwtBearerTokenFlow: add additional setter to request an opaque token response

Co-authored-by: Kalin Borisov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants