Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose http status code in OAuth2ServiceException #1251

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

Exotrom
Copy link
Contributor

@Exotrom Exotrom commented Aug 3, 2023

Expose the httpStatusCode field from OAuth2ServiceException.

It has been like this before, but the method had been removed in #1179.
If there is no reason not to expose it to the caller, we would like to have it back as our current code is relying on it for error handling.

Copy link

@DirkG68 DirkG68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The status code is needed to determine the root cause and provide valuable feedback during support

Copy link
Contributor

@liga-oz liga-oz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR 💯 it looks like it was removed by mistake, it'll be available again in the next release, which is going out today.

@liga-oz liga-oz merged commit 30e863f into SAP:main Aug 3, 2023
4 checks passed
@Exotrom Exotrom deleted the oauth-exception-provide-status branch August 3, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants