make the class fields more restrictive

Signed-off-by: liga-oz <[email protected]>
SAP · Jan 4, 2024 · 32539e7 · 32539e7
1 parent 303a81d
commit 32539e7
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/java-security/src/main/java/com/sap/cloud/security/servlet/HybridTokenFactory.java b/java-security/src/main/java/com/sap/cloud/security/servlet/HybridTokenFactory.java
@@ -32,8 +32,8 @@
 public class HybridTokenFactory implements TokenFactory {
 
 	private static final Logger LOGGER = LoggerFactory.getLogger(HybridTokenFactory.class);
-	protected static Optional<String> xsAppId;
-	protected static ScopeConverter xsScopeConverter;
+	static Optional<String> xsAppId;
+	static ScopeConverter xsScopeConverter;
 
 	/**
 	 * Determines whether the JWT token is issued by XSUAA or IAS identity service,
@@ -84,10 +84,13 @@ private static Optional<String> getXsAppId() {
 		}
 		OAuth2ServiceConfiguration serviceConfiguration = Environments.getCurrent().getXsuaaConfiguration();
 		if (serviceConfiguration != null) {
-			return xsAppId = Optional.of(serviceConfiguration.getProperty(CFConstants.XSUAA.APP_ID));
+			xsAppId = Optional.of(serviceConfiguration.getProperty(CFConstants.XSUAA.APP_ID));
+		} else {
+			LOGGER.warn(
+					"There is no xsuaa service configuration with 'xsappname' property: no local scope check possible.");
+			xsAppId = Optional.empty();
 		}
-		LOGGER.warn("There is no xsuaa service configuration with 'xsappname' property: no local scope check possible.");
-		return xsAppId = Optional.empty();
+		return xsAppId;
 	}
 
 	/**