feat: 🎸 [HCPSDKFIORIUIKIT-2964] SwiftUI Hierarchy View #1310

JunSong-SH · 2025-10-28T10:57:23Z

[HCPSDKFIORIUIKIT-2964] SwiftUI Hierarchy View

This PR address the change for SwiftUI Hierarchy View migration according to the UIkit Hierarchy View. The main changes include the following items:

Migrated most of functions except the async loading, iPad layout and copiable function.
Added demo example for HierarchyView and HierarchyItemView.
Added the Unit test for HierarchyView.

hound · 2025-10-28T10:57:27Z

Sources/FioriSwiftUICore/DataTypes/HierarchyView+DataType.swift

+    // Wrapper the header's trailing accessory clickable with default logic both the default and customized trailing accessory
+    init(_ configuration: TrailingAccessoryConfiguration, modelObject: HierarchyViewModelObject, isRTL: Bool) {
+        let trailingAccessory: () -> AnyView = {
+            if let _ = isRTL ? modelObject.parentID : modelObject.childID, let _ = modelObject.currentID {


Unused Optional Binding Violation: Prefer != nil over let _ = (unused_optional_binding)

hound · 2025-10-28T10:57:27Z

Sources/FioriSwiftUICore/DataTypes/HierarchyView+DataType.swift

+    // Wrapper the header's leading accessory clickable with default logic both the default and customized leading accessory
+    init(_ configuration: LeadingAccessoryConfiguration, modelObject: HierarchyViewModelObject, isRTL: Bool) {
+        let leadingAccessory: () -> AnyView = {
+            if let _ = isRTL ? modelObject.childID : modelObject.parentID, let _ = modelObject.currentID {


Unused Optional Binding Violation: Prefer != nil over let _ = (unused_optional_binding)

hound · 2025-10-28T10:57:27Z

Sources/FioriSwiftUICore/DataTypes/HierarchyView+DataType.swift

+    // Wrapper the header's trailing accessory clickable with default logic both the default and customized trailing accessory
+    init(_ configuration: TrailingAccessoryConfiguration, modelObject: HierarchyViewModelObject, isRTL: Bool) {
+        let trailingAccessory: () -> AnyView = {
+            if let _ = isRTL ? modelObject.parentID : modelObject.childID, let _ = modelObject.currentID {


Unused Optional Binding Violation: Prefer != nil over let _ = (unused_optional_binding)

hound · 2025-10-28T10:57:27Z

Sources/FioriSwiftUICore/DataTypes/HierarchyView+DataType.swift

+    // Wrapper the header's leading accessory clickable with default logic both the default and customized leading accessory
+    init(_ configuration: LeadingAccessoryConfiguration, modelObject: HierarchyViewModelObject, isRTL: Bool) {
+        let leadingAccessory: () -> AnyView = {
+            if let _ = isRTL ? modelObject.childID : modelObject.parentID, let _ = modelObject.currentID {


Unused Optional Binding Violation: Prefer != nil over let _ = (unused_optional_binding)

cla-assistant · 2025-10-28T10:57:37Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ dyongxu
✅ JunSong-SH
❌ I063052

I063052 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

dyongxu · 2025-10-28T18:58:54Z

@JunSong-SH I used copilot to generate the API doc, you can review it and see if to be adopted. It is for HierarchyView. I have not used it for other public APIs yet. You may see if copilot helps with your other public APIs as well

/// HierarchyView displays tree-structured data using HierarchyItemView rows and an optional HierarchyHeader.
///
/// ### Overview
/// Use HierarchyView when you need to browse, navigate, and (optionally) select items in a hierarchical data set (parent/child relationships).
/// The component delegates data access to a HierarchyViewDataSource so large or dynamic trees can be served efficiently.
///
/// ### Key Features
/// - Pluggable data source (HierarchyViewDataSource) defining root, children, parent lookups, and titles.
/// - Custom per-item view content via the hierarchyItem closure.
/// - Optional header view for navigation controls / summary information.
/// - Built-in selection handling (single / multiple / none) controlled by the hierarchyItemSelectionMode environment value.
/// - Style system (Fiori & custom) applied through hierarchyViewStyle modifiers.
///
/// ### Data Source Contract (Summary)
/// Your data source must provide stable, unique String identifiers for every item. Child counts and IDs should remain consistent during a single render pass.
/// See HierarchyViewDataSource for full protocol requirements.
///
/// ### State Bindings
/// - activeChildItem: The identifier that will become active (e.g. next navigated child) when the user invokes forward navigation in the header.
/// - selectedItems: Collection of currently selected item IDs (optional array in the generated initializer).
/// In single-selection mode only the first element is considered; in multiple-selection mode all elements are used.
///
/// ### Selection Mode
/// Controlled externally via environment:
/// swift /// .environment(\.hierarchyItemSelectionMode, .none) // selection disabled /// .environment(\.hierarchyItemSelectionMode, .single) // single selection /// .environment(\.hierarchyItemSelectionMode, .multiple) // multi selection ///
/// Selection affordances (selection buttons) are only visible while EditMode is .active and the selection mode is not .none.
///
/// ### Usage
/// #### 1. Simple Initialization (generated initializer)
/// swift /// @State private var activeChild: String? = nil /// @State private var selected: [String]? = [] /// let dataSource = HierarchySimpleDataSource() /// /// HierarchyView( /// dataSource: dataSource, /// hierarchyItem: { id in Text(id) }, /// activeChildItem: $activeChild, /// selectedItems: $selected /// ) /// .environment(\.editMode, .constant(.active)) /// .environment(\.hierarchyItemSelectionMode, .multiple) ///
///
/// #### 2. Single Selection Convenience (see public API extension)
/// swift /// @State private var activeChild: String? = nil /// @State private var selected: String? = nil /// HierarchyView.singleSelection( /// dataSource: dataSource, /// hierarchyItem: { id in Text(id) }, /// activeChildItem: $activeChild, /// selectedItem: $selected /// ) /// .environment(\.hierarchyItemSelectionMode, .single) ///
///
/// #### 3. Multi Selection With Set (see public API extension)
/// swift /// @State private var activeChild: String? = nil /// @State private var selectedSet: Set<String> = [] /// HierarchyView.multiSelection( /// dataSource: dataSource, /// hierarchyItem: { id in Text(id) }, /// activeChildItem: $activeChild, /// selectedItems: $selectedSet /// ) /// .environment(\.hierarchyItemSelectionMode, .multiple) ///
///
/// ### Styling
/// Apply or compose styles using:
/// swift /// HierarchyView(...) /// .hierarchyViewStyle(MyCustomHierarchyStyle()) ///
/// Custom styles implement HierarchyViewStyle and can be layered; the environment maintains an internal style stack.
///
/// ### Performance Tips
/// - Provide O(1) or cached implementations for child count / child ID queries.
/// - Use stable IDs; avoid generating random IDs each render.
/// - Prefer lazy expansion of deep branches (render children only when needed) in your item view logic.
///
/// ### See Also
/// HierarchyViewDataSource, HierarchyItemView, HierarchyHeader, HierarchyIndicator, HierarchyViewStyle.

Sources/FioriSwiftUICore/_ComponentProtocols/CompositeComponentProtocols.swift

dyongxu

Enhance API doc and unit test, Try to hit 80% code coverage
The fiori icons come from Design Team. So, usually we don't add our new icons, since they follow some design pattern.
This PR adds some new icons , does it mean UIKit SDK uses different icons ?

Sources/FioriSwiftUICore/_ComponentProtocols/CompositeComponentProtocols.swift

...tUICore/_generated/StyleableComponents/HierarchyIndicator/HierarchyIndicator.generated.swift

...iftUICore/_generated/StyleableComponents/HierarchyItemView/HierarchyItemView.generated.swift

.../FioriSwiftUICore/_generated/StyleableComponents/HierarchyView/HierarchyView.generated.swift

dyongxu · 2025-10-28T19:33:15Z

@JunSong-SH See if these files (with low or 0%)c an be covered in unit tests. You can try to use copilot to write unit tests

JunSong-SH · 2025-10-29T06:22:32Z

Enhance API doc and unit test, Try to hit 80% code coverage

The fiori icons come from Design Team. So, usually we don't add our new icons, since they follow some design pattern.
This PR adds some new icons , does it mean UIKit SDK uses different icons ?

The two newly added icons come from the FioriIcon library used in the UIKit HierarchyIndicator. See below links:
https://github.tools.sap/Tango/SAPFiori/tree/main/src/Frameworks/SAPFiori/SAPFiori/OfficialFioriIcons.xcassets/iOS%20SDK%20Library/SFSymbols/hierarchy.off.symbolset
https://github.tools.sap/Tango/SAPFiori/tree/main/src/Frameworks/SAPFiori/SAPFiori/OfficialFioriIcons.xcassets/iOS%20SDK%20Library/SFSymbols/hierarchy.on.symbolset
However, they are not present in the FioriIcon library used for SwiftUI Fiori controls, so I assume they should be added.

JunSong-SH · 2025-11-03T08:06:40Z

Enhance unit test and API doc.

hound · 2025-11-03T14:16:12Z

Sources/FioriSwiftUICore/_FioriStyles/AccessoryViewStyle.fiori.swift

+import Foundation
+import SwiftUI
+
+/**
