Repository navigation
Conversation
Use mutex locks to ensure maxSubscriptions is properly managed: appLocks sync.Map to SubscriptionHandler and a lockApp(appIdHash) helper that lazily creates and acquires a per-application mutex (different apps never block each other). *Note:* Cross-replica caveat & follow-up (not implemented here). The mutex coordinates requests within one pod only. subscriptionServer.replicas is configurable (default 1); with >1 replica, pods can still interleave List/Create and overshoot the limit. Strict cross-replica enforcement would use a per-app distributed lock via a coordination.k8s.io/v1 Lease (capop-sublimit-<appIdHash>): acquire by Get→Create-if-absent / take-if-expired-or-ours via Update with resourceVersion (409-retry), holderIdentity from a POD_NAME env var, leaseDurationSeconds tuned above a single Create but short enough to bound stall on holder crash, release by Update/Delete. This needs leases RBAC added to the subscription-server Role in the cap-operator-lifecycle Helm chart (cross-repo). client-go leaderelection is a poor fit (long-lived leader election, not short per-request locks). Recommended interim guidance: run the subscription server with a single replica for strict enforcement.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use mutex locks to ensure maxSubscriptions is properly managed: appLocks sync.Map to SubscriptionHandler and a lockApp(appIdHash) helper that lazily creates and acquires a per-application mutex (different apps never block each other).
Note:
Cross-replica caveat & follow-up (not implemented here). The mutex coordinates requests within one pod only. subscriptionServer.replicas is configurable (default 1); with >1 replica, pods can still interleave List/Create and overshoot the limit. Strict cross-replica enforcement would use a per-app distributed lock via a coordination.k8s.io/v1 Lease (capop-sublimit-): acquire by Get→Create-if-absent / take-if-expired-or-ours via Update with resourceVersion (409-retry), holderIdentity from a POD_NAME env var, leaseDurationSeconds tuned above a single Create but short enough to bound stall on holder crash, release by Update/Delete. This needs leases RBAC added to the subscription-server Role in the cap-operator-lifecycle Helm chart (cross-repo). client-go leaderelection is a poor fit (long-lived leader election, not short per-request locks). Recommended interim guidance: run the subscription server with a single replica for strict enforcement.