Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAPOperator CRD change #23

Merged
merged 4 commits into from
Sep 26, 2023
Merged

CAPOperator CRD change #23

merged 4 commits into from
Sep 26, 2023

Conversation

anirudhprasad-sap
Copy link
Contributor

  • Moved dnsTarget out of subscriptionServer.
  • Added oneOf required to CRD for dnsTarget and ingressGatewayLabels
  • Adopted transformer and the tests

@anirudhprasad-sap
Copy link
Contributor Author

anirudhprasad-sap commented Sep 26, 2023 •
edited
Loading

Test Image- ghcr.io/anirudhprasad-sap/cap-operator-lifecycle/cap-operator-manager:test-2

@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Pavan-SAP
Pavan-SAP approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@Pavan-SAP Pavan-SAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔

@anirudhprasad-sap anirudhprasad-sap merged commit 9bd6043 into main Sep 26, 2023
8 checks passed
@anirudhprasad-sap anirudhprasad-sap deleted the crdChange branch September 26, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pavan-SAP Pavan-SAP Pavan-SAP approved these changes

@skrishnan-sap skrishnan-sap Awaiting requested review from skrishnan-sap

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anirudhprasad-sap @Pavan-SAP