Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: CRON Job for Auto Merging Dependabot PRs #215

Merged
merged 6 commits into from
May 2, 2024

Conversation

Johannes-Schneider
Copy link
Contributor

@Johannes-Schneider Johannes-Schneider commented May 2, 2024

This PR refactors our automated PR merging for Dependabot PRs in a way that the workflow is triggered on a schedule instead of triggering right after the PR creation.

The old approach has shown to be non-functioning as the workflow was triggered by an external user (i.e. Dependabot), which (we assume) prevented the workflow from accessing any our secrets.
As a consequence, the workflow always failed.

This updated approach does not run into that issue as the workflow is not triggered by an external user.
So we can safely access all of our secrets.

Example workflow run
Example merged PR

@Johannes-Schneider Johannes-Schneider marked this pull request as ready for review May 2, 2024 07:09
@MatKuhr MatKuhr merged commit 8cb09c8 into main May 2, 2024
7 checks passed
@MatKuhr MatKuhr deleted the refactor/dependabot-automerge branch May 2, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants