Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Consider SERVICE_BINDING_ROOT Env Var for Layered Bindings #213

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Johannes-Schneider
Copy link
Contributor

Context

This PR extends the SapServiceOperatorLayeredServiceBindingAccessor to also consider the SERVICE_BINDING_ROOT environment variable for binding the root path of the mounted service bindings.
Hereby, we are supporting the Proposed CF Extension.

Feature Scope

  • Consider the SERVICE_BINDING_ROOT env var whenever we are reading service bindings

Release Notes

Module: java-sap-service-operator

  • Feature: The SapServiceOperatorLayeredServiceBindingAccessor now considers the SERVICE_BINDING_ROOT environment variable for finding the root location of mounted service bindings. If that variable is not defined, the accessor falls back to the default root location (/etc/secrets/sapbtp).

Definition of Done

  • Feature scope is implemented
  • Feature scope is tested
  • Feature scope is documented
  • Release notes are created

@Johannes-Schneider Johannes-Schneider marked this pull request as draft May 2, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant