refactor: CVE Caching #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johannes-Schneider
added
do not review
added 5 commits
March 26, 2024 11:49
Johannes-Schneider
added
please review
MatKuhr
approved these changes
Mar 26, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR refactors how the caching of the Vulnerability (i.e. CVE) database works.
Previously (without the suggested changes), we are trying to update the database on every build pipeline run.
This approach, however, leads to a dead lock due to (most probably) the matrix build we are using.
To fix this issue, we are now introducing one workflow (the
Update Vulnerabilities Databaseone) that runs on a fixed schedule and replaces the existing GH actions cache with an updated version.Build pipeline runs will then use this cache (or fail if the cache isn't present) and skip updating the vulnerability database.
This drastically increases the build pipeline runtime.