async-profiler#993: Filter native frames in allocation profile: OpenJ…

…9 and stripped symbols
SAP · Sep 15, 2024 · c299592 · c299592
1 parent e6a1581
commit c299592
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/src/codeCache.cpp b/src/codeCache.cpp
@@ -114,6 +114,11 @@ void CodeCache::mark(NamePredicate predicate, char value) {
             NativeFunc::mark(blob_name, value);
         }
     }
+
+    if (value == MARK_VM_RUNTIME && _name != NULL) {
+        // In case a library has no debug symbols
+        NativeFunc::mark(_name, value);
+    }
 }
 
 CodeBlob* CodeCache::findBlob(const char* name) {

diff --git a/src/vmEntry.cpp b/src/vmEntry.cpp
@@ -67,11 +67,24 @@ static bool isOpenJ9JitStub(const char* blob_name) {
         blob_name += 3;
         return strcmp(blob_name, "NewObject") == 0
             || strcmp(blob_name, "NewArray") == 0
-            || strcmp(blob_name, "ANewArray") == 0;
+            || strcmp(blob_name, "ANewArray") == 0
+            || strcmp(blob_name, "AMultiNewArray") == 0;
     }
     return false;
 }
 
+static bool isOpenJ9Resolve(const char* blob_name) {
+    return strncmp(blob_name, "resolve", 7) == 0;
+}
+
+static bool isOpenJ9JitAlloc(const char* blob_name) {
+    return strncmp(blob_name, "old_", 4) == 0;
+}
+
+static bool isOpenJ9GcAlloc(const char* blob_name) {
+    return strncmp(blob_name, "J9Allocate", 10) == 0;
+}
+
 static bool isCompilerEntry(const char* blob_name) {
     return strncmp(blob_name, "_ZN13CompileBroker25invoke_compiler_on_method", 45) == 0;
 }
@@ -153,9 +166,15 @@ bool VM::init(JavaVM* vm, bool attach) {
     VMStructs::init(lib);
     if (isOpenJ9()) {
         lib->mark(isOpenJ9InterpreterMethod, MARK_INTERPRETER);
+        lib->mark(isOpenJ9Resolve, MARK_VM_RUNTIME);
         CodeCache* libjit = profiler->findJvmLibrary("libj9jit");
         if (libjit != NULL) {
             libjit->mark(isOpenJ9JitStub, MARK_INTERPRETER);
+            libjit->mark(isOpenJ9JitAlloc, MARK_VM_RUNTIME);
+        }
+        CodeCache* libgc = profiler->findJvmLibrary("libj9gc");
+        if (libgc != NULL) {
+            libgc->mark(isOpenJ9GcAlloc, MARK_VM_RUNTIME);
         }
     } else {
         lib->mark(isVmRuntimeEntry, MARK_VM_RUNTIME);