chore: Add cache for deployment ID #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marikaner
changed the title
marikaner
commented
Sep 2, 2024
marikaner
commented
Sep 2, 2024
tomfrenken
reviewed
Sep 2, 2024
tomfrenken
reviewed
Sep 2, 2024
deekshas8
reviewed
Sep 2, 2024
tomfrenken
reviewed
Sep 2, 2024
tomfrenken
approved these changes
Sep 2, 2024
MatKuhr
reviewed
Sep 2, 2024
| ).toEqual('deployment-id1'); | ||
| }); | ||
|
|
||
| it('should ignore model versions without model name', () => { |
There was a problem hiding this comment.
any particular reason why? Ideally, this never happens, right?
There was a problem hiding this comment.
Yes, I wanted to make sure that we don't accidentally allow it though. The way we build the cache key this should not be possible anyways.
MatKuhr
reviewed
Sep 2, 2024
Comment on lines
+53
to
+54
| name: 'gpt-35-turbo', | ||
| version: 'latest' |
There was a problem hiding this comment.
I would expect the test to pass with the following change, but it fails:
Suggested change
| name: 'gpt-35-turbo', | |
| version: 'latest' | |
| name: 'gpt-35-turbo' |
MatKuhr
reviewed
Sep 2, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
AI/gen-ai-hub-sdk-js-backlog#78.
Introduce a cache for deployment IDs.
I did not offer a possibility for users to change the default validity time, let me know if you see reasons to introduce this.
For langchain integration we will probably need to cache model information as well. I am wondering whether we should cache the ID + model or just the whole deployment directly. @MatKuhr @deekshas8 @tomfrenken
Definition of Done