chore: Add smoke test #80
Conversation
# Conflicts: # pnpm-lock.yaml
marikaner
requested review from
deekshas8,
MatKuhr,
KavithaSiva and
tomfrenken
| * Ask GPT about the capital of France. | ||
| * @returns The answer from the orchestration service in Gen AI Hub. | ||
| */ | ||
| export function orchestrationCompletion(): Promise<CompletionPostResponse> { |
There was a problem hiding this comment.
[q] We could consider calling this from the e2e test, similar to how we do it for OpenAI. That way we gain additional confidence this code actually works 😉
# Conflicts: # package.json # pnpm-lock.yaml
| module.exports = { | ||
| hooks: { | ||
| afterAllResolved: async lockfile => { | ||
| // Object.keys(lockfile.packages) |
There was a problem hiding this comment.
Nope, I want to keep this for the follow up, because this code will most likely be needed for it.
|
Also, the pipeline seems to fail because cloud foundry installs node 18, I suppose you need to adjust the manifest.yaml to select node 20. |
Co-authored-by: Tom Frenken <[email protected]>
Co-authored-by: Tom Frenken <[email protected]>
Co-authored-by: Tom Frenken <[email protected]>
@tomfrenken I wonder where you got this idea? To me it seems that I deleted a script during clean up. I added it back, should work now. |
sample-code/src/server.ts
Outdated
|
|
||
| app.get('/ai-core/get-deployments', async (req, res) => { | ||
| try { | ||
| res.send(await chatCompletion()); |
There was a problem hiding this comment.
Is this correct? shouldn't we call getDeployments function?
There was a problem hiding this comment.
oopsie, good catch
Add smoke tests using the sample code.