chore: Restructure packages #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marikaner
previously approved these changes
Aug 13, 2024
packages/core/README.md
Outdated
There was a problem hiding this comment.
[req] There should be at least something in this file... This will be the front page on npm.
There was a problem hiding this comment.
Added basic info for now.
Co-authored-by: Marika Marszalkowski <[email protected]>
Co-authored-by: Marika Marszalkowski <[email protected]>
tomfrenken
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
corepackage (name can be discussed)test-util, at the same level aspackages.Right now, in ai-sdk I get the error: 'rootDir' is expected to contain all source files.This is fixed using the tsconfig.test.json setting.Update
We decided to not use the
jest.unstable_mockModulefor mocking thegetAiCoreDestinationfunction due to multiple issues. We will use the jest globalSetup and teardown to mock an env variable for unit testing.