-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add content filtering with convenience functions #58
Conversation
…m:SAP/ai-sdk-js into feat/add-content-filtering-with-functions
Co-authored-by: Kuhr, Matthias <[email protected]>
…m:SAP/ai-sdk-js into feat/add-content-filtering-with-functions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Nice that we have the test coverage and also the option for the default filter, where no config is given.
Maybe someone else wants to look more closely at the TS coding details, but semantically it makes sense to me 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the outcome. I think it makes sense to allow both variants and the convenient variant is easy to consume. One thing to consider in the future is, if discoverability can be improved when there are multiple services in orchestration.
packages/gen-ai-hub/src/orchestration/orchestration-client.test.ts
Outdated
Show resolved
Hide resolved
packages/gen-ai-hub/src/orchestration/orchestration-filter-utility.test.ts
Show resolved
Hide resolved
packages/gen-ai-hub/src/orchestration/orchestration-filter-utility.test.ts
Outdated
Show resolved
Hide resolved
packages/gen-ai-hub/src/orchestration/orchestration-filter-utility.test.ts
Outdated
Show resolved
Hide resolved
packages/gen-ai-hub/src/orchestration/orchestration-filter-utility.test.ts
Outdated
Show resolved
Hide resolved
packages/gen-ai-hub/src/orchestration/orchestration-filter-utility.ts
Outdated
Show resolved
Hide resolved
packages/gen-ai-hub/src/orchestration/orchestration-filter-utility.ts
Outdated
Show resolved
Hide resolved
packages/gen-ai-hub/src/orchestration/orchestration-filter-utility.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Marika Marszalkowski <[email protected]>
…lity.test.ts Co-authored-by: Marika Marszalkowski <[email protected]>
…lity.ts Co-authored-by: Marika Marszalkowski <[email protected]>
…lity.ts Co-authored-by: Marika Marszalkowski <[email protected]>
…lity.ts Co-authored-by: Marika Marszalkowski <[email protected]>
…lity.test.ts Co-authored-by: Marika Marszalkowski <[email protected]>
…lity.test.ts Co-authored-by: Marika Marszalkowski <[email protected]>
Proposed state:
or you could assign
filterConfig
property with the content filtering JSON structure the orchestration service accepts:Note: I also re-generated the orchestration client.