Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Follow-up Documentation cleanup #159
chore: Follow-up Documentation cleanup #159
Changes from 57 commits
7239bbb
f89fc29
971883e
8072128
f39f044
9028c12
e0f2033
df50cd1
7390dbe
8506bd6
361940b
ef23a7c
d62d62d
98fa3b4
f1991b1
864f041
7b94a23
9333645
63fd72c
94c3d8a
4c8ce4f
87a2ac0
124a0d8
54f7815
0f34a2d
d5856df
45b547e
2e29d74
8fd9186
76f5dd3
408b0a1
0016f88
756b5df
41c0b84
129bdeb
0a2a768
728abe2
afb3a95
267a6f7
53b14e2
cd54014
b379d9e
40e7409
688af41
9e26d5a
d7f9522
69afd57
e24d8ad
7af7b3b
508fee5
697e2c9
1425977
5d40c54
ecf5c01
831b355
5358ad1
bce751d
57c02a0
37f23a7
8188acc
05d15b8
59cb45a
1838278
9eff8b0
9926785
3a70dc7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Subtle differences between the two, so I will use the original sentence, as it talks about relationship rather than what is required by the API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as before, a bit confusing to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[pp] I would suggest we extract this section into a separate file as it has been repeated many times. It will be very hard to maintain so many packages. At least we should do this definitely in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As, the deployment requirements change between orchestration and foundation-models. I would prefer to write about it in the dedicated client document instead of a separate file, as this would be more confusing.