Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix release pipeline #132

Merged
merged 38 commits into from
Sep 16, 2024
Merged

chore: Fix release pipeline #132

merged 38 commits into from
Sep 16, 2024

Conversation

marikaner
Copy link
Contributor

@marikaner marikaner commented Sep 13, 2024

Context

AI/gen-ai-hub-sdk-js-backlog#85.

Use reusable github actions from SAP Cloud SDK for JS.
This should only be merged after SAP/cloud-sdk-js#4993.

.github/workflows/bump.yml Outdated Show resolved Hide resolved
.github/workflows/bump.yml Outdated Show resolved Hide resolved
.github/workflows/bump.yml Outdated Show resolved Hide resolved
@marikaner marikaner changed the title chore: fix release pipeline chore: Fix release pipeline Sep 13, 2024
# - uses: sap/cloud-sdk-js/.github/actions/get-changelog@main
# name: Get Changelog
# id: get-changelog
- uses: sap/cloud-sdk-js/.github/actions/merge-changelogs@main
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[q] Just for my understanding, we don't call this in the bump action because we dont want to maintain a root CHANGELOG.md?

Copy link
Member

@tomfrenken tomfrenken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marikaner marikaner merged commit cfe9408 into main Sep 16, 2024
9 of 10 checks passed
@marikaner marikaner deleted the ga-release branch September 16, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants