Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add AI Core e2e tests #128
feat: Add AI Core e2e tests #128
Changes from 12 commits
334708d
2cb350a
4f6a002
e163d42
6a3883b
7f8cf16
bf650a8
87793a2
4f69da8
748e921
85b9af2
a876bb4
21a655f
650e2c7
cc018f4
425330e
388401b
1524acb
e2aabab
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[pp] I think it would be better if we could have a way to run the tests independently. In case something is not working, I would always have to run all tests in order, so local testing is a bit difficult: I couldn't run one test at a time...
My thoughts:
I expect that we have no running deployments before we run the tests. This means when I would like to run the modification or deletion test, I couldn't run this test individually.
A fix could be that I have to run the creation manually before (e.g. running the creation test) and then to run modification individually, query the deployment instead of keeping a global state.
This is still inconvenient, so the tests could try to retrieve the global state, if not set query the deployment, if not there create it as needed.
Another thought is - if tests fail or are cancelled before they are finished, it is possible that we accumulate more and more deployments - I guess we should consider some kind of a clean up step.
I guess 1. could be a bit overkill or could be done later. I think 2. could be useful.
Thoughts @deekshas8 @MatKuhr @ZhongpinWang @KavithaSiva @tomfrenken
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could use jest's pattern matching to run individual tests but also keep this flow? Plus we also add a cleanup step as you mentioned.