Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use literal string for orchestration models #125

Merged
merged 11 commits into from
Sep 12, 2024

Conversation

ZhongpinWang
Copy link
Contributor

@ZhongpinWang ZhongpinWang commented Sep 10, 2024

Context

AI/gen-ai-hub-sdk-js-backlog#102.

Model name autocompletion is supported now:

image

Custom strings are also allowed in case some model has not been included in the list yet.

Model types moved to @sap-ai-sdk/core for reuse by both foundation-models and orchestration packages.

Definition of Done

  • Code is tested (Unit, E2E)
  • Error handling created / updated & covered by the tests above
  • Documentation updated
  • (Optional) Aligned changes with the Java SDK
  • (Optional) Release notes updated

packages/core/src/model-types.ts Show resolved Hide resolved
packages/core/src/model-types.ts Outdated Show resolved Hide resolved
tests/type-tests/test/model.test-d.ts Show resolved Hide resolved
tests/type-tests/test/openai.test-d.ts Show resolved Hide resolved
Copy link
Contributor

@marikaner marikaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments, but I have no concerns.

packages/core/src/model-types.ts Show resolved Hide resolved
packages/core/src/model-types.ts Show resolved Hide resolved
packages/core/src/model-types.ts Outdated Show resolved Hide resolved
@ZhongpinWang ZhongpinWang merged commit 6f3b31e into main Sep 12, 2024
9 checks passed
@ZhongpinWang ZhongpinWang deleted the feat-use-literal-string-for-orchestration-models branch September 12, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants