feat(test): Add unit tests for aicore-clients #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into ai-core-client-tests merge
deekshas8
reviewed
Jul 9, 2024
KavithaSiva
reviewed
Jul 15, 2024
KavithaSiva
reviewed
Jul 15, 2024
deekshas8
reviewed
Jul 15, 2024
… into ai-core-client-tests merge latest
deekshas8
reviewed
Jul 19, 2024
deekshas8
reviewed
Jul 19, 2024
|
|
||
| nock(destination.url).get('/lm/artifacts').reply(200, expectedResponse, { | ||
| 'Content-Type': 'application/json', | ||
| 'AI-Resource-Group': 'default' |
There was a problem hiding this comment.
[q] Aren't these part of the request header?
There was a problem hiding this comment.
You're right. The resource group is only a part of the request header. Only content type should be a part of response. Thanks for catching it.
There was a problem hiding this comment.
I would also not bother so much with response headers for now.
deekshas8
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds unit tests for the AI core clients generated by using Cloud SDK. The following 5 AI Core endpoints covered:
Closes AI/gen-ai-hub-sdk-js#47