fix errors

SAP · Aug 8, 2024 · 8ba04c2 · 8ba04c2
1 parent 89230a3
commit 8ba04c2
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 18 deletions.
diff --git a/packages/ai-core/package.json b/packages/ai-core/package.json
@@ -21,7 +21,7 @@
     "test": "NODE_OPTIONS=--experimental-vm-modules jest",
     "lint": "eslint . && prettier . --config ../../.prettierrc --ignore-path ../../.prettierignore -c",
     "lint:fix": "eslint . --fix && prettier . --config ../../.prettierrc --ignore-path ../../.prettierignore -w --log-level error",
-    "generate": "openapi-generator --options-per-service='./spec/options-per-service.json' --generateESM  --overwrite --input spec/AI_CORE_API.yaml --outputDir ."
+    "generate": "openapi-generator --options-per-service='./spec/options-per-service.json' --generateESM  --overwrite --input spec/AI_CORE_API.yaml --outputDir . && pnpm lint:fix"
   },
   "dependencies": {
     "@sap-cloud-sdk/openapi": "^3.18.0"

diff --git a/packages/gen-ai-hub/package.json b/packages/gen-ai-hub/package.json
@@ -23,7 +23,7 @@
     "test": "NODE_OPTIONS=--experimental-vm-modules jest",
     "lint": "eslint . && prettier . --config ../../.prettierrc --ignore-path ../../.prettierignore -c",
     "lint:fix": "eslint . --fix && prettier . --config ../../.prettierrc --ignore-path ../../.prettierignore -w --log-level error",
-    "generate:orchestration": "openapi-generator --options-per-service='./src/orchestration/spec/options-per-service.json' --overwrite --generateESM -i ./src/orchestration/spec/api.yaml -o ./src/orchestration",
+    "generate:orchestration": "openapi-generator --options-per-service='./src/orchestration/spec/options-per-service.json' --overwrite --generateESM -i ./src/orchestration/spec/api.yaml -o ./src/orchestration && pnpm lint:fix",
     "postgenerate": "ts-node ../../scripts/update-imports.ts src/orechestration/api"
   },
   "dependencies": {

diff --git a/packages/gen-ai-hub/src/orchestration/orchestration-client.ts b/packages/gen-ai-hub/src/orchestration/orchestration-client.ts
@@ -40,6 +40,8 @@ export function constructCompletionPostRequest(
   input: GenAiHubCompletionParameters
 ): CompletionPostRequest {
   return {
+    // TODO: Properly implement input params
+    input_params: {},
     orchestration_config: {
       module_configurations: {
         templating_module_config: {

diff --git a/tests/type-tests/orchestration.test-d.ts b/tests/type-tests/orchestration.test-d.ts
@@ -100,22 +100,6 @@ expectError<any>(
   })
 );
 
-/**
- * Role in prompt template can only be user|assistant|system.
- */
-expectError<any>(
-  client.chatCompletion({
-    deploymentConfiguration: { deploymentId: 'id' },
-    prompt: {
-      template: [{ role: 'actor', content: 'Hello!' }]
-    },
-    llmConfig: {
-      model_name: 'gpt-35-turbo-16k',
-      model_params: {}
-    }
-  })
-);
-
 /**
  * Model parameters should adhere to OrchestrationCompletionParameters.// Todo: Check if additional checks can be added for model_params.
  */