-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Orchestration, Spring AI and Everything Else #96
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please split this PR in 2: first Orchestration Client and then Spring AI.
I did my best to review this but it's very early.
@RequiredArgsConstructor | ||
class OrchestrationResponseHandler<T> implements HttpClientResponseHandler<T> { | ||
// TODO reduce code duplication with OpenAI | ||
@Nonnull private final Class<T> responseType; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is 99% code duplication with OpenAIResponseHandler
@Test | ||
void looseFilter() { | ||
assertThat(new OrchestrationController().filter("4")).isNotNull(); | ||
} | ||
|
||
@Test | ||
void strictFilter() { | ||
assertThatThrownBy(() -> new OrchestrationController().filter("0")) | ||
.isInstanceOf(HttpClientErrorException.class) | ||
.hasMessageContaining("400 Bad Request"); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove my tests?
Context
Yes, context.
Feature scope:
Yes.
Definition of Done
Error handling created / updated & covered by the tests aboveAligned changes with the JavaScript SDKDocumentation updatedRelease notes updated