chore: Translation Module Convenience #646
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orchestration/src/main/java/com/sap/ai/sdk/orchestration/model/SAPDocumentTranslationInput.java
Outdated
Show resolved
Hide resolved
…into translation-module-convenience
…into translation-module-convenience
…into translation-module-convenience
…into translation-module-convenience
…into translation-module-convenience
# Conflicts: # orchestration/src/main/java/com/sap/ai/sdk/orchestration/model/SAPDocumentTranslationOutput.java
newtork
reviewed
Nov 10, 2025
| .config( | ||
| SAPDocumentTranslationOutputConfig.create() | ||
| .targetLanguage(SAPDocumentTranslationOutputTargetLanguage.create("de-DE")) | ||
| .sourceLanguage("en-US")); |
Contributor
There was a problem hiding this comment.
(Major)
These arguments need to be configurable fully for the convenience layer.
newtork
reviewed
Nov 10, 2025
| SAPDocumentTranslationInputConfig.create() | ||
| .targetLanguage("en-US") | ||
| .applyTo(null))) | ||
| TranslationConfig.inputTranslation().getInputTranslationConfig()) |
Contributor
There was a problem hiding this comment.
(Minor)
I would expect an overload for .withInputTranslationConfig(..) that expects a convenience class as argument, in parallel to existing generated class SAPDocumentTranslationOutput.
Contributor
There was a problem hiding this comment.
Please compare to the other with- methods in OrchestrationModuleConfig, they translate a convenience argument to generated class.
Jonas-Isr
reviewed
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
AI/ai-sdk-java-backlog#325.
Adding convenience methods for both input and output translation configs respectively.
Feature scope:
Definition of Done
Aligned changes with the JavaScript SDK