Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Streaming] Fix issues when not using try-with-resource #49

Open
wants to merge 92 commits into
base: main
Choose a base branch
from
Open

[Streaming] Fix issues when not using try-with-resource #49

wants to merge 92 commits into from

Commits on Aug 16, 2024

  1. OpenAI streaming

    @CharlesDuboisSAP
    CharlesDuboisSAP committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    d319aa9 View commit details
    Browse the repository at this point in the history

  2. Added homepage and error handling todo

    @CharlesDuboisSAP
    CharlesDuboisSAP committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    69ae7eb View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. Renamed vars

    @CharlesDuboisSAP
    CharlesDuboisSAP committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    7870e6d View commit details
    Browse the repository at this point in the history

  2. Added todos

    @CharlesDuboisSAP
    CharlesDuboisSAP committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    652ec1e View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Made stream generic, try-with resources, TEXT_EVENT_STREAM, exception… 

    … refactored
    @CharlesDuboisSAP
    CharlesDuboisSAP committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    727b3d4 View commit details
    Browse the repository at this point in the history

  2. Formatting

    @bot-sdk-js
    bot-sdk-js committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    b3190a5 View commit details
    Browse the repository at this point in the history

  3. close stream correctly

    @CharlesDuboisSAP
    CharlesDuboisSAP committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    f0fa3e6 View commit details
    Browse the repository at this point in the history

  4. Formatting

    @bot-sdk-js
    bot-sdk-js committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    09ca6ea View commit details
    Browse the repository at this point in the history

  5. Created OpenAiStreamOutput

    @CharlesDuboisSAP
    CharlesDuboisSAP committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    d86243a View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/streaming' into streaming

    @CharlesDuboisSAP
    CharlesDuboisSAP committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    2a4ce7b View commit details
    Browse the repository at this point in the history

  7. Formatting

    @bot-sdk-js
    bot-sdk-js committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    cf6ec46 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. Renamed stream to streamChatCompletion, Added comments

    @CharlesDuboisSAP
    CharlesDuboisSAP committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    a73f037 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. Added total output

    @CharlesDuboisSAP
    CharlesDuboisSAP committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    eb3f24a View commit details
    Browse the repository at this point in the history

  2. Total output is printed

    @CharlesDuboisSAP
    CharlesDuboisSAP committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    fb2cdaf View commit details
    Browse the repository at this point in the history

  3. Formatting

    @bot-sdk-js
    bot-sdk-js committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    fe078c7 View commit details
    Browse the repository at this point in the history

  4. addDelta is propagated everywhere

    @CharlesDuboisSAP
    CharlesDuboisSAP committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    09e1be0 View commit details
    Browse the repository at this point in the history

  5. addDelta is propagated everywhere

    @CharlesDuboisSAP
    CharlesDuboisSAP committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    42ae946 View commit details
    Browse the repository at this point in the history

  6. forgotten addDeltas

    @CharlesDuboisSAP
    CharlesDuboisSAP committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    e6e009a View commit details
    Browse the repository at this point in the history

  7. Added jackson dependencies

    @CharlesDuboisSAP
    CharlesDuboisSAP committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    bee8fdc View commit details
    Browse the repository at this point in the history

  8. Added Javadoc

    @CharlesDuboisSAP
    CharlesDuboisSAP committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    5f03c6f View commit details
    Browse the repository at this point in the history

  9. Removed 1 TODO

    @CharlesDuboisSAP
    CharlesDuboisSAP committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    e79ca8e View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. PMD

    @CharlesDuboisSAP
    CharlesDuboisSAP committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    ba2c5e0 View commit details
    Browse the repository at this point in the history

  2. PMD again

    @CharlesDuboisSAP
    CharlesDuboisSAP committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    c10eecb View commit details
    Browse the repository at this point in the history

  3. Merge branch 'refs/heads/main' into streaming

    @CharlesDuboisSAP
    CharlesDuboisSAP committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    cdae1c6 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'refs/heads/main' into streaming

    @CharlesDuboisSAP
    CharlesDuboisSAP committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    faa3b70 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Added OpenAiClientTest.streamChatCompletion()

    @CharlesDuboisSAP
    CharlesDuboisSAP committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    0e1a167 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. Change return type of stream, added e2e test

    @CharlesDuboisSAP
    CharlesDuboisSAP committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    31dbd52 View commit details
    Browse the repository at this point in the history

  2. Added documentation

    @CharlesDuboisSAP
    CharlesDuboisSAP committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    de7e7f0 View commit details
    Browse the repository at this point in the history

  3. Added documentation framework-agnostic + throw if finish reason is in… 

    …valid
    @CharlesDuboisSAP
    CharlesDuboisSAP committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    349936f View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. Merge branch 'refs/heads/main' into streaming

    @CharlesDuboisSAP
    CharlesDuboisSAP committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    58b0bc9 View commit details
    Browse the repository at this point in the history

  2. Added error handling test

    @CharlesDuboisSAP
    CharlesDuboisSAP committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    3366c2e View commit details
    Browse the repository at this point in the history

  3. Updates from pair review / discussion

    @MatKuhr
    MatKuhr committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    c709d31 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2024

  1. Cleanup + streamChatCompletion doesn't throw

    @CharlesDuboisSAP
    CharlesDuboisSAP committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    73031d1 View commit details
    Browse the repository at this point in the history

  2. PMD

    @CharlesDuboisSAP
    CharlesDuboisSAP committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    6b1bfd0 View commit details
    Browse the repository at this point in the history

  3. Added errorHandling test

    @CharlesDuboisSAP
    CharlesDuboisSAP committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    23474ba View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Matthias Kuhr <[email protected]>
    @CharlesDuboisSAP @MatKuhr
    CharlesDuboisSAP and MatKuhr authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    769cd7d View commit details
    Browse the repository at this point in the history

  2. Dependency analyze

    @CharlesDuboisSAP
    CharlesDuboisSAP committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    118dc69 View commit details
    Browse the repository at this point in the history

  3. Review comments

    @CharlesDuboisSAP
    CharlesDuboisSAP committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    acd21c0 View commit details
    Browse the repository at this point in the history

  4. Make client static

    @CharlesDuboisSAP
    CharlesDuboisSAP committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    28268b2 View commit details
    Browse the repository at this point in the history

  5. Formatting

    @bot-sdk-js
    bot-sdk-js committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    9a9a44b View commit details
    Browse the repository at this point in the history

  6. PMD

    @CharlesDuboisSAP
    CharlesDuboisSAP committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    788db03 View commit details
    Browse the repository at this point in the history

  7. Fix tests

    @CharlesDuboisSAP
    CharlesDuboisSAP committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    0616f55 View commit details
    Browse the repository at this point in the history

  8. Removed exception constructors no args

    @CharlesDuboisSAP
    CharlesDuboisSAP committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    3446bf0 View commit details
    Browse the repository at this point in the history

  9. Refactor exception message

    @CharlesDuboisSAP
    CharlesDuboisSAP committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    45a20c6 View commit details
    Browse the repository at this point in the history

  10. Readme sentences

    @CharlesDuboisSAP
    CharlesDuboisSAP committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    f843061 View commit details
    Browse the repository at this point in the history

  11. Remove superfluous call super

    @CharlesDuboisSAP
    CharlesDuboisSAP committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    5edcf71 View commit details
    Browse the repository at this point in the history

  12. reset httpclient-cache and -factory after each test case

    @newtork
    newtork committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    7474fb1 View commit details
    Browse the repository at this point in the history

  13. Very minor code-style improvements in test

    @newtork
    newtork committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    ac6f36c View commit details
    Browse the repository at this point in the history

  14. Minor code-style in OpenAIController

    @newtork
    newtork committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    ffa369a View commit details
    Browse the repository at this point in the history

  15. Reduce README sample code

    @newtork
    newtork committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    6cfeee9 View commit details
    Browse the repository at this point in the history

  16. Update OpenAiStreamingHandler.java (#43)

    @newtork
    newtork authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    6d4fd2f View commit details
    Browse the repository at this point in the history

  17. Fix import

    @newtork
    newtork committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    a6c566a View commit details
    Browse the repository at this point in the history

  18. Initial

    @newtork
    newtork committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    543e003 View commit details
    Browse the repository at this point in the history

  19. Format

    @newtork
    newtork committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    e810b52 View commit details
    Browse the repository at this point in the history

  20. Improve type

    @newtork
    newtork committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    89b7315 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Added stream_options to model

    @CharlesDuboisSAP
    CharlesDuboisSAP committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    f6a4fe6 View commit details
    Browse the repository at this point in the history

  2. Change Executor#submit() to #execute()

    @newtork
    newtork committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    ead57b3 View commit details
    Browse the repository at this point in the history

  3. Change Executor#submit() to #execute()

    @newtork
    newtork committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    05dedf9 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'streaming' of https://github.com/SAP/ai-sdk-java into s… 

    …treaming
    @newtork
    newtork committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    2604969 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/main' into streaming

    @newtork
    newtork committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    9a3bf2f View commit details
    Browse the repository at this point in the history

  6. Added usage testing

    @CharlesDuboisSAP
    CharlesDuboisSAP committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    a0ae779 View commit details
    Browse the repository at this point in the history

  7. Added beautiful Javadoc to enableStreaming

    @CharlesDuboisSAP
    CharlesDuboisSAP committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    2c934f7 View commit details
    Browse the repository at this point in the history

  8. typo

    @CharlesDuboisSAP
    CharlesDuboisSAP committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    77eb464 View commit details
    Browse the repository at this point in the history

  9. Fix mistake

    @CharlesDuboisSAP
    CharlesDuboisSAP committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    488f060 View commit details
    Browse the repository at this point in the history

  10. Merge remote-tracking branch 'origin/streaming' into streaming-2

    @newtork
    newtork committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    b5f48cd View commit details
    Browse the repository at this point in the history

  11. Merge remote-tracking branch 'origin/main' into streaming-2 

    # Conflicts:
#	README.md
#	foundation-models/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiStreamingHandler.java
    @newtork
    newtork committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    06e3143 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Syntax improvement to improve API stability.

    @newtork
    newtork committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    676c8ad View commit details
    Browse the repository at this point in the history

  2. Syntax improvement to improve API stability.

    @newtork
    newtork committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    93e16d9 View commit details
    Browse the repository at this point in the history

  3. Make exception types similar to BufferedReader original logic

    @newtork
    newtork committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    6e15131 View commit details
    Browse the repository at this point in the history

  4. Format

    @newtork
    newtork committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    f6f122d View commit details
    Browse the repository at this point in the history

  5. Add nonnull characteristic to mirror BufferedReader original logic

    @newtork
    newtork committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    7aad621 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. Merge branch 'main' into streaming-2

    @newtork
    newtork authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    58e84b2 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Merge remote-tracking branch 'origin/main' into streaming-2

    @newtork
    newtork committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    db05057 View commit details
    Browse the repository at this point in the history

  2. Make buffer size accessible

    @a-d
    a-d committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    9188893 View commit details
    Browse the repository at this point in the history

  3. Add test

    @a-d
    a-d committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    67a0489 View commit details
    Browse the repository at this point in the history

  4. Add assertion on stream count

    @a-d
    a-d committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    20cc897 View commit details
    Browse the repository at this point in the history

  5. Simplify e2e code

    @a-d
    a-d committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    f4947a8 View commit details
    Browse the repository at this point in the history

  6. Simplify README

    @a-d
    a-d committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    98e61de View commit details
    Browse the repository at this point in the history

  7. Partially revert

    @a-d
    a-d committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    d034d2a View commit details
    Browse the repository at this point in the history

  8. Add assertion

    @a-d
    a-d committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    aa7ae8e View commit details
    Browse the repository at this point in the history

  9. Partially revert

    @a-d
    a-d committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    66ad4d7 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Merge remote-tracking branch 'origin/main' into streaming-2

    @a-d
    a-d committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    9dcb57a View commit details
    Browse the repository at this point in the history

  2. Minor code adjustments

    @a-d
    a-d committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    7b275df View commit details
    Browse the repository at this point in the history

  3. Replace unnecessary nested types

    @a-d
    a-d committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    2e2c0df View commit details
    Browse the repository at this point in the history

  4. Merge nested type to renamed parent type

    @a-d
    a-d committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    fa284ad View commit details
    Browse the repository at this point in the history

  5. Change code to ensure our lazy hasNext() has no unexpected side effect

    @a-d
    a-d committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    cde54d6 View commit details
    Browse the repository at this point in the history

  6. Revert removing emitter#complete()

    @a-d
    a-d committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    5088b99 View commit details
    Browse the repository at this point in the history

  7. Add JavaDoc; Replace VAVR type

    @a-d
    a-d committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    fa8f91d View commit details
    Browse the repository at this point in the history

  8. Address PMD warnings: change exception type

    @a-d
    a-d committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    e90883e View commit details
    Browse the repository at this point in the history

  9. Add unhappy-path test cases

    @a-d
    a-d committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    4183ca3 View commit details
    Browse the repository at this point in the history

  10. Revert code change in test app

    @a-d
    a-d committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    1463eb2 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'main' into streaming-2

    @newtork
    newtork authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    9fb63e3 View commit details
    Browse the repository at this point in the history