feat: [Orchestration] Adding New Models #485
Merged
+108
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newtork
previously approved these changes
Jul 8, 2025
jjtang1985
previously requested changes
Jul 8, 2025
There was a problem hiding this comment.
I'm afraid, after this PR, we will not have the latest status.
Please have a look at my comments here
rpanackal
reviewed
Jul 9, 2025
There was a problem hiding this comment.
In the meantime there has been changes to the model list in SAP Notes.. We may have also missed to clean up some of the old models in the enum list.
I have listed the changes w.r.t your PR against the current state of SAP notes.
orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationAiModel.java
Show resolved
Hide resolved
orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationAiModel.java
Show resolved
Hide resolved
# Conflicts: # docs/release_notes.md
…tratonAiModel Class
… into Adding-new-orchestration-models
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
AI/ai-sdk-java-backlog#274.
New models like mistralai--mistral-small-instruct, nvidia--llama-3.2-nv-embedqa-1b, amazon--titan-embed-text, gpt-4.1-mini, gpt-4.1, gpt-4.1-nano are not "officially supported" by the SDK.
Feature scope:
Adding New Models
Definition of Done
Error handling created / updated & covered by the tests aboveAligned changes with the JavaScript SDKDocumentation updated