Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run PMD by default #106

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Run PMD by default #106

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fd61df4
Fix plugins path root declarations; Make PMD run by default
a-d Oct 18, 2024
3ad86da
Formatting
bot-sdk-js Oct 18, 2024
df571e7
Print errors to console
a-d Oct 18, 2024
475ea13
Merge remote-tracking branch 'origin/pmd/run-by-default' into pmd/run…
a-d Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,9 +396,9 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<version>3.5.0</version>
<configuration>
<configLocation>.pipeline/checkstyle.xml</configLocation>
<configLocation>${project.rootdir}/.pipeline/checkstyle.xml</configLocation>
<!-- Exclude generated clients -->
<suppressionsLocation>.pipeline/checkstyle-suppressions.xml</suppressionsLocation>
<suppressionsLocation>${project.rootdir}/.pipeline/checkstyle-suppressions.xml</suppressionsLocation>
<linkXRef>false</linkXRef>
</configuration>
<dependencies>
Expand All @@ -415,29 +415,37 @@
<version>3.25.0</version>
<configuration>
<rulesets>
<ruleset>.pipeline/pmd.xml</ruleset>
<ruleset>.pipeline/sdk_specific_pmd_rules.xml</ruleset>
<ruleset>${project.rootdir}/.pipeline/pmd.xml</ruleset>
<ruleset>${project.rootdir}/.pipeline/sdk_specific_pmd_rules.xml</ruleset>
<!-- content of the PMD default rule set for Java can be found here:
https://gitbox.apache.org/repos/asf?p=maven-pmd-plugin.git;a=blob_plain;f=src/main/resources/rulesets/java/maven-pmd-plugin-default.xml;hb=HEAD -->
<ruleset>/rulesets/java/maven-pmd-plugin-default.xml</ruleset>
</rulesets>
<linkXRef>false</linkXRef>
<targetJdk>${maven.compiler.release}</targetJdk>
<printFailingErrors>true</printFailingErrors>
<excludes>
<!-- Exclude generated clients -->
<exclude>com/sap/ai/sdk/core/client/**/*</exclude>
<exclude>com/sap/ai/sdk/orchestration/client/**/*</exclude>
</excludes>
</configuration>
<executions>
<execution>
<goals>
<goal>check</goal>
</goals>
<phase>verify</phase>
</execution>
</executions>
</plugin>
<plugin>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
<version>4.8.6.4</version>
<configuration>
<includeFilterFile>.pipeline/spotbugs.xml</includeFilterFile>
<includeFilterFile>${project.rootdir}/.pipeline/spotbugs.xml</includeFilterFile>
<!-- Exclude generated clients -->
<excludeFilterFile>.pipeline/spotbugs-exclusions.xml</excludeFilterFile>
<excludeFilterFile>${project.rootdir}/.pipeline/spotbugs-exclusions.xml</excludeFilterFile>
<effort>Max</effort>
<threshold>Low</threshold>
<maxHeap>2048</maxHeap>
Expand Down