Added resource group isolation to DeploymentCache #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CharlesDuboisSAP
changed the title
MatKuhr
reviewed
Oct 18, 2024
| .orElseThrow( | ||
| () -> | ||
| new NoSuchElementException( | ||
| "No running deployment found for scenario: " + scenarioId)); | ||
| }); | ||
| } | ||
|
|
||
| private Optional<String> getDeploymentIdByScenario(@Nonnull final String scenarioId) { | ||
| return CACHE.stream() | ||
| private Optional<String> getDeploymentIdByScenario( |
There was a problem hiding this comment.
(minor) It would be nice to stick to either VAVRs Option<> or Javas Optional. Mixing the two is a bit awkward, and mixing them in public API might be confusing for users. In Cloud SDK we used VAVR because it's more powerful and integrated with Try etc.
There was a problem hiding this comment.
This is not public API it's just a private helper function to reduce code duplication.
MatKuhr
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
AI/ai-sdk-java-backlog#54.
The deployment cache needs to isolate between resource groups.
Also customers should be able to reset the cache
Feature scope:
AiCoreService.resetCache(client, resourceGroup)Definition of Done
Aligned changes with the JavaScript SDKDocumentation updatedRelease notes updated