chore: Include License in Release JAR Files #101
Merged
+28
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <!-- include LICENSE in all jar files --> | ||
| <resource> | ||
| <filtering>false</filtering> | ||
| <directory>${project.rootdir}</directory> |
There was a problem hiding this comment.
Suggested change
| <directory>${project.rootdir}</directory> | |
| <directory>${user.dir}</directory> |
That allows you to remove all project.rootdir properties
There was a problem hiding this comment.
This is not safe, because it depends from which directory the JVM was run. This might change e.g. if we make changes to how our GH actions work, or when running locally, etc.
The problem is if this points to the wrong dir, we won't notice it because there is no error thrown or anything. So considering some options this seems to be the most reliable way. See also this thread.
CharlesDuboisSAP
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Required by OSPO