Update run_poe_model.rsc #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add variable max_iter for the maximum feedback iteration Update macro "CreateBatchFile"
Replace Java dependent package "xlsx" with non-Java dependent "openxlsx" Remove hard coded 0.9 factor on first iteration (it is already specified in config input) Use join statements in calculating hourly processed volume
Correct fatal error under these two situations: 1. When there are initial queues specified in configuration 2. When there are unprocessed vehicle at the end of the day
jielin-sun
approved these changes
Aug 13, 2020
jielin-sun
reviewed
Aug 13, 2020
| des_outcomes_df <- Compute_Weighted_Average_Wait_Time(des_outcomes_df, prior_des_outcomes_df, 0.9) | ||
| # Chi Ping Lam 7/23/2020 | ||
| # For the first iteration, the des_outcomes_df should be simply the rsesult of first simulation | ||
| # and there is need to compute a weighted average (no previous result!) |
jielin-sun
approved these changes
Aug 13, 2020
jielin-sun
approved these changes
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add variable max_iter for the maximum feedback iteration at the beginning of the code (Better readability)
Update macro "CreateBatchFile" to 1. add title to the window 2. correct quotation issue