added basic logging and updated environment variables #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friedelwolff
requested changes
Apr 26, 2024
README.md
Outdated
|
|
||
| Add the following folders to the Docker container: |
There was a problem hiding this comment.
Since this is Docker, let's use Docker terminology. Maybe something like "Mount volumes at the following locations:" ?
There was a problem hiding this comment.
This can be added to the prod docker-compose file
daniel-gray-tangent
force-pushed
the
feature/logging
branch
2 times, most recently
from
729f314
to
916e7fb
Compare
friedelwolff
requested changes
Apr 30, 2024
.env.example
Outdated
| DB_NAME=term_db | ||
| DB_USER=sadilar | ||
| DB_PASSWORD=sadilar | ||
| LOGGING_FILE=logs/debug.log |
There was a problem hiding this comment.
Different default than the one in the code, in case you want to make that consistent.
There was a problem hiding this comment.
This is addressed and fixed in current merge of code
README.md
Outdated
| @@ -24,8 +24,16 @@ About the project: | |||
| 3. Run `make run` to run the docker container | |||
| 4. Run `make stop` to stop the docker container | |||
|
|
|||
| ## Production | |||
There was a problem hiding this comment.
please review trailing spaces.
daniel-gray-tangent
force-pushed
the
feature/logging
branch
from
916e7fb
to
9e3931b
Compare
daniel-gray-tangent
force-pushed
the
feature/logging
branch
5 times, most recently
from
607898b
to
57d5556
Compare
daniel-gray-tangent
force-pushed
the
feature/logging
branch
6 times, most recently
from
c6f8454
to
eae3c24
Compare
friedelwolff
requested changes
May 8, 2024
- added github actions testing - updated enviroment variables in settings - added tests for logging files - updated setting to check for testing
daniel-gray-tangent
force-pushed
the
feature/logging
branch
from
c5eb17e
to
9ab5035
Compare
friedelwolff
approved these changes
May 8, 2024
takealot38-github
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.