Repository navigation
block-padding+inout: remove std feature - #1117
Merged
Merged
Conversation
Leverages the `error_in_core` feature stabilized in Rust 1.81 to allow `Error` trait impls in `no_std` contexts. This was the only dependency on `std`, so this also removes the `std` feature, which is no longer necessary.
tarcieri
changed the title
std featurestd feature
newpavlov
approved these changes
Sep 28, 2024
newpavlov
left a comment
newpavlov
left a comment
Member
There was a problem hiding this comment.
We also probably can remove the [package.metadata.docs.rs] section as well.
tarcieri
commented
Sep 28, 2024
Comment on lines
-21
to
-22
| [package.metadata.docs.rs] | ||
| all-features = true |
Member
Author
There was a problem hiding this comment.
Looks like we still need the all-features = true here because of the block-padding feature.
I think --cfg docsrs might be set automatically now though?
Member
There was a problem hiding this comment.
I think --cfg docsrs might be set automatically now though?
It would be great, if true. We should eventually remove it from other crates then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leverages the
error_in_corefeature stabilized in Rust 1.81 to allowErrortrait impls inno_stdcontexts.This was the only dependency on
std, so this also removes thestdfeature, which is no longer necessary.