Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cipher: remove needless lifetimes #1368

Merged
merged 1 commit into from
Oct 27, 2023
Merged

cipher: remove needless lifetimes #1368

merged 1 commit into from
Oct 27, 2023

Conversation

tarcieri
Copy link
Member

One of the lifetimes is unused, but we couldn't remove it before because it would be a breaking change.

Closes #1336

newpavlov
newpavlov reviewed Oct 27, 2023
View reviewed changes
Copy link
Member

@newpavlov newpavlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have missed a bunch of other methods with this issue. I guess Clippy should highlight them, if not, then its version should be bumped.

@tarcieri
Copy link
Member Author

tarcieri commented Oct 27, 2023 •
edited
Loading

I can't reproduce any failures with the latest stable clippy version

$ cargo clippy -- --version
clippy 0.1.73 (cc66ad46 2023-10-03)
$ cargo clippy -- -D warnings
    Checking crypto-common v0.2.0-pre (/Users/tony/src/RustCrypto/traits/crypto-common)
    Checking cipher v0.5.0-pre (/Users/tony/src/RustCrypto/traits/cipher)
    Finished dev [unoptimized + debuginfo] target(s) in 0.19s

Edit: never mind, needed --all-features

@tarcieri tarcieri force-pushed the cipher/remove-needless-lifetime branch from fb4a899 to fe8c2d0 Compare October 27, 2023 18:41
@tarcieri tarcieri changed the title cipher: remove needless lifetime from encrypt_padded_inout cipher: remove needless lifetimes Oct 27, 2023
@tarcieri
cipher: remove needless lifetimes
e8055e3 
One of the lifetimes is unused, but we couldn't remove it before because
it would be a breaking change.

Closes #1336
@tarcieri tarcieri force-pushed the cipher/remove-needless-lifetime branch from fe8c2d0 to e8055e3 Compare October 27, 2023 18:42
@tarcieri tarcieri merged commit 2a1016f into master Oct 27, 2023
9 checks passed
@tarcieri tarcieri deleted the cipher/remove-needless-lifetime branch October 27, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newpavlov newpavlov newpavlov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cipher: resolve clippy::needless_lifetimes lint
2 participants
@tarcieri @newpavlov