chacha20: Improve quality of StreamId From impls and some related documentation
#392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...and improve consistency of some documentation
silverstillisntgold
changed the title
StreamId impls and some related documentationStreamId From impls and some related documentation
silverstillisntgold
changed the title
StreamId From impls and some related documentationStreamId From impls and some related documentation
tarcieri
reviewed
Feb 18, 2025
|
cc @nstilt1 |
Sometime in the next few months, probably. We need to release the upstream trait crates first: RustCrypto/traits#1571 |
|
Fair enough, but is there any chance of cutting a pre.4 release for the endianness fixes from #389? |
|
Sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got rid of some magic numbers, improved readability, and removed duplicate code. Also marked these functions as
#[inline], since they get compiled into a few moves (I've checked that this is the case for all three of them).Any idea when
chacha20will be ready for a full 0.10.0 release?