Skip to content

Commit

Permalink
keccak: 2021 edition upgrade; MSRV 1.59
Browse files Browse the repository at this point in the history
`keccak` was previously excluded from the toplevel workspace due to its
MSRV of 1.41 and incompatibilities with packages used by `ascon`.

This bumps the edition, changes the version to `0.2.0-pre` to denote it
contains breaking changes (though this is not intended to be a
`0.2.0-pre` release), and bumps MSRV 1.59 so that the crate has a single
consistent MSRV regardless of whether or not the `asm` feature is
enabled.

With the MSRV bumped, `keccak` can and has been re-added to the toplevel
workspace.
  • Loading branch information
tarcieri committed Jan 12, 2024
1 parent 40c50c1 commit 75debec
Show file tree
Hide file tree
Showing 7 changed files with 30 additions and 33 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/keccak.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
set-msrv:
uses: RustCrypto/actions/.github/workflows/set-msrv.yml@master
with:
msrv: 1.41.0
msrv: 1.59.0

build:
needs: set-msrv
Expand Down
22 changes: 22 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[workspace]
exclude = ["keccak"] # TODO(tarcieri): add back to `members` when MSRV >= 1.56
resolver = "2"
members = [
"ascon",
#"keccak",
"keccak",
]
25 changes: 0 additions & 25 deletions keccak/Cargo.lock

This file was deleted.

5 changes: 3 additions & 2 deletions keccak/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "keccak"
version = "0.1.5"
version = "0.2.0-pre"
description = """
Pure Rust implementation of the Keccak sponge function including the keccak-f
and keccak-p variants
Expand All @@ -12,7 +12,8 @@ repository = "https://github.com/RustCrypto/sponges/tree/master/keccak"
keywords = ["crypto", "sponge", "keccak", "keccak-f", "keccak-p"]
categories = ["cryptography", "no-std"]
readme = "README.md"
edition = "2018"
edition = "2021"
rust-version = "1.56"

[features]
asm = [] # Use optimized assembly when available (currently only ARMv8)
Expand Down
4 changes: 2 additions & 2 deletions keccak/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ is built on this crate.

## Minimum Supported Rust Version

Rust **1.41** or higher by default, or **1.59** with the `asm` feature enabled.
Rust **1.59** or higher.

Minimum supported Rust version can be changed in the future, but it will be
done with a minor version bump.
Expand Down Expand Up @@ -56,7 +56,7 @@ dual licensed as above, without any additional terms or conditions.
[build-image]: https://github.com/RustCrypto/sponges/actions/workflows/keccak.yml/badge.svg
[build-link]: https://github.com/RustCrypto/sponges/actions/workflows/keccak.yml
[license-image]: https://img.shields.io/badge/license-Apache2.0/MIT-blue.svg
[rustc-image]: https://img.shields.io/badge/rustc-1.41+-blue.svg
[rustc-image]: https://img.shields.io/badge/rustc-1.59+-blue.svg
[chat-image]: https://img.shields.io/badge/zulip-join_chat-blue.svg
[chat-link]: https://rustcrypto.zulipchat.com/#narrow/stream/369879-sponges

Expand Down
1 change: 0 additions & 1 deletion keccak/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@
)]

use core::{
convert::TryInto,
fmt::Debug,
mem::size_of,
ops::{BitAnd, BitAndAssign, BitXor, BitXorAssign, Not},
Expand Down

0 comments on commit 75debec

Please sign in to comment.