Implement MultipartSigner/Verifier
#982
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
It would be good to add it to (Maybe we can add a macro to write impls for types which impl |
daxpedda
force-pushed
the
multi-part-sign-verify
branch
from
5c3f521 to
ea896d2
Compare
|
Done. Just leaving a list of potentially other applicable implementations:
|
|
There's also |
|
Just a thought I had: we could expose the new private functions in ML-DSA and SLH-DSA as |
Let me know if you want me to add if there as well. |
daxpedda
changed the title
MultiPartSigner/Verifier for ML-DSA and SLH-DSAMultipartSigner/Verifier for ML-DSA and SLH-DSA
daxpedda
changed the title
MultipartSigner/Verifier for ML-DSA and SLH-DSAMultipartSigner/Verifier
tarcieri
pushed a commit
to RustCrypto/traits
that referenced
this pull request
Jun 2, 2025
This PR adds new traits for multipart messages: `MultipartSigner`, `RandomizedMultipartSigner`, `RandomizedMultipartSignerMut` and `MultipartVerifier`. The idea here is to allow non-contiguous bytes to be passed, which is necessary when the message has to be constructed from multiple sources without wanting to allocate memory for a contiguous message. E.g. for `no_std` environments or when the message is rather big but pre-hashing is not applicable, e.g. PureEdDSA, ML-DSA or SLH-DSA. I know this is a rather big breaking change, so let me know what you think! These new traits can be implemented by a bunch of crates: - [x] `ecdsa`: RustCrypto/signatures#982 - [x] `ml-dsa`: RustCrypto/signatures#982 - [x] `slh-dsa`: RustCrypto/signatures#982 - [x] `bign256`: RustCrypto/elliptic-curves#1221 - [x] `sm2`: RustCrypto/elliptic-curves#1221 - [x] `k256`: RustCrypto/elliptic-curves#1221 - [x] `dsa`: RustCrypto/signatures#982 - [x] `lms`: RustCrypto/signatures#982 - [x] `rsa`: RustCrypto/RSA#525 - [ ] `ed25519-dalek` Resolves RustCrypto/signatures#959.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of
MultipartSignerandMultipartVerifieradded in RustCrypto/traits#1880.The implementation in ML-DSA and SLH-DSA is not ideal. Basically all the relevant functions are public and only take
&[u8]. So instead of changing public functions, I just moved the implementation of those functions into private functions that take&[&[u8]]. Let me know if you want me to solve this in any other way.