ecdsa: refactor Signature
constructors and improve docs
#730
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
from_bytes
in terms offrom_scalars
, rather than the other way around.This places the logic for checking that
r
ands
are nonzero inside of thefrom_scalars
method.Additionally improves the documentation to note the various failure cases, i.e. if
r
and/ors
is out of the range1..n
, wheren
is the scalar modulus.