Add various hybrid array sizes necessary for Kemeleon #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmwample
added a commit
to jmwample/kemeleon
that referenced
this pull request
Sep 1, 2024
|
Thanks! |
tarcieri
pushed a commit
that referenced
this pull request
Sep 15, 2024
In a previous pull request #84 I added several sizes, but mistook the direction of the binary representation of the added values. Along with that one of the sizes was calculated incorrectly. (My apologies!) This corrects both of those errors, successfully tested using the downstream library. Also I checked (via script) all of the other binary representations and and they all match the assigned values. Co-authored-by: jmwample <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am working on implementing an obfuscated encoding for ML-KEM encapsulation keys and ciphertexts and there are several non-standard array sizes that will make inter-operating between the custom library and
ml-kemsignificantly easier. These would also be useful if the kemeleon encoding strategy is eventually added as a feature inside theml-kemcrate itself.The encoding and decoding algorithms are described in section 2.4 of Obfuscated Key Exchange by Günther, Stebila, and Veitch. The output byte array sizes are described in
Table 2on page 8.