Make new UInt definition less verbose#51
Merged
tarcieri merged 1 commit intoRustCrypto:masterfrom Feb 19, 2024
Merged
Conversation
tarcieri
approved these changes
Feb 19, 2024
Member
|
Thanks! Definitely an improvement |
Contributor
Author
|
BTW, I figured out how to make it big-endian. Requires some trait and associated type magic, but works fine. LMK if this seems worthwhile and I can make a PR. |
Member
|
I'm fine with it being little endian, especially as an internal macro |
Contributor
Author
|
If only there were a way to expand an integer into its bits in the macro syntax! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a macro that simplifies the definition of new integer values, and uses it for the integers we need to define here. It allows a new
UInttype to be defined simply by listing its bits. Unfortunately, because Rust macros only permit recursive matching in one direction, we have to use the little-endian bit order, even though big-endian would be easier to read.Not a huge change, but it at least allows us to remove the
#[rustfmt::skip]line.