Bump `digest` to v0.11.0-pre.3; MSRV 1.71 #523

tarcieri · 2023-12-31T20:07:38Z

Also bumps crate editions to 2021 where appropriate

newpavlov

You forgot to update MSRV in a number of crate readmes.

newpavlov · 2024-01-04T19:43:11Z

whirlpool/src/lib.rs

@@ -170,7 +170,7 @@ const BLOCK_SIZE: usize = <WhirlpoolCore as BlockSizeUser>::BlockSize::USIZE;

 #[inline(always)]
 fn convert(blocks: &[Block<WhirlpoolCore>]) -> &[[u8; BLOCK_SIZE]] {
-    // SAFETY: GenericArray<u8, U64> and [u8; 64] have
+    // SAFETY: Array<u8, U64> and [u8; 64] have
    // exactly the same memory layout
    let p = blocks.as_ptr() as *const [u8; BLOCK_SIZE];
    unsafe { core::slice::from_raw_parts(p, blocks.len()) }


It could be worth to remove unsafe lines like this by adding a conversion method to the ArrayOps trait.

Let's save that for a followup, but I agree

newpavlov · 2024-01-04T19:44:11Z

tiger/src/lib.rs

@@ -14,7 +14,7 @@
 //! // process input message
 //! hasher.update(b"hello world");
 //!
-//! // acquire hash digest in the form of GenericArray,
+//! // acquire hash digest in the form of Array,


Suggested change

//! // acquire hash digest in the form of Array,

//! // acquire hash in the form of `hybrid_array::Array`,

newpavlov · 2024-01-04T19:53:00Z

skein/benches/skein512.rs

@@ -1,7 +1,7 @@
 #![feature(test)]
 extern crate test;

-use digest::{bench_update, generic_array::typenum::U64};
+use digest::{array::typenum::U64, bench_update};


Suggested change

use digest::{array::typenum::U64, bench_update};

use digest::{typenum::U64, bench_update};

newpavlov · 2024-01-04T19:53:10Z

skein/benches/skein256.rs

@@ -1,7 +1,7 @@
 #![feature(test)]
 extern crate test;

-use digest::{bench_update, generic_array::typenum::U32};
+use digest::{array::typenum::U32, bench_update};


Suggested change

use digest::{array::typenum::U32, bench_update};

use digest::{typenum::U32, bench_update};

newpavlov · 2024-01-04T19:53:19Z

skein/benches/skein1024.rs

@@ -1,7 +1,7 @@
 #![feature(test)]
 extern crate test;

-use digest::{bench_update, generic_array::typenum::U128};
+use digest::{array::typenum::U128, bench_update};


Suggested change

use digest::{array::typenum::U128, bench_update};

use digest::{typenum::U128, bench_update};

newpavlov · 2024-01-04T20:04:38Z

md4/src/lib.rs

@@ -12,7 +12,7 @@
 //! // process input message
 //! hasher.update(b"hello world");
 //!
-//! // acquire hash digest in the form of GenericArray,
+//! // acquire hash digest in the form of Array,


Suggested change

//! // acquire hash digest in the form of Array,

//! // acquire hash in the form of `hybrid_array::Array<u8, U16>`,

newpavlov · 2024-01-04T20:05:15Z

jh/src/lib.rs

@@ -49,13 +49,13 @@ pub use digest::{self, Digest};
 use crate::compressor::Compressor;
 use core::fmt;
 use digest::{
+    array::typenum::{Unsigned, U28, U32, U48, U64},


Suggested change

array::typenum::{Unsigned, U28, U32, U48, U64},

typenum::{Unsigned, U28, U32, U48, U64},

newpavlov · 2024-01-04T20:05:54Z

groestl/src/lib.rs

@@ -12,7 +12,7 @@
 //! // process input message
 //! hasher.update(b"my message");
 //!
-//! // acquire hash digest in the form of GenericArray,
+//! // acquire hash digest in the form of Array,


Suggested change

//! // acquire hash digest in the form of Array,

//! // acquire hash in the form of `hybrid_array::Array<u8, U32>`,

newpavlov · 2024-01-04T20:06:13Z

gost94/src/lib.rs

@@ -11,7 +11,7 @@
 //! // process input message
 //! hasher.update("The quick brown fox jumps over the lazy dog");
 //!
-//! // acquire hash digest in the form of GenericArray,
+//! // acquire hash digest in the form of Array,


Suggested change

//! // acquire hash digest in the form of Array,

//! // acquire hash in the form of `hybrid_array::Array<u8, U32>`,

newpavlov · 2024-01-04T20:08:22Z

belt-hash/src/lib.rs

@@ -13,7 +13,7 @@
 //! // process input message
 //! hasher.update(b"hello world");
 //!
-//! // acquire hash digest in the form of GenericArray,
+//! // acquire hash digest in the form of Array,


Suggested change

//! // acquire hash digest in the form of Array,

//! // acquire hash in the form of `hybrid_array::Array<u8, U32>`,

newpavlov

I will do a follow-up PR a bit later.

The new MSRV after #523 is 1.71

tarcieri added 5 commits December 31, 2023 13:07

[WIP] Bump digest to v0.11.0-pre; MSRV 1.65

2b98104

Also bumps crate editions to 2021 where appropriate

rustfmt

59789af

Bump MSRVs and dependency versions

fb54e93

sha1: fix Windows tests

bd84553

blake2: disable simd build

7073367

tarcieri changed the title ~~[WIP] Bump digest to v0.11.0-pre; MSRV 1.65~~ Bump digest to v0.11.0-pre.1; MSRV 1.65 Jan 3, 2024

tarcieri marked this pull request as ready for review January 3, 2024 00:04

tarcieri requested a review from newpavlov January 3, 2024 00:04

tarcieri force-pushed the digest/v0.11.0-pre branch from 0c342cb to fbd933f Compare January 3, 2024 22:45

tarcieri changed the title ~~Bump digest to v0.11.0-pre.1; MSRV 1.65~~ Bump digest to v0.11.0-pre.2; MSRV 1.65 Jan 3, 2024

newpavlov reviewed Jan 4, 2024

View reviewed changes

tarcieri changed the title ~~Bump digest to v0.11.0-pre.2; MSRV 1.65~~ Bump digest to v0.11.0-pre.3; MSRV 1.71 Jan 6, 2024

tarcieri force-pushed the digest/v0.11.0-pre branch from fbd933f to 6fd20b4 Compare January 6, 2024 05:05

Bump digest dependency to v0.11.0-pre.3

794bd1e

tarcieri force-pushed the digest/v0.11.0-pre branch from 6fd20b4 to 794bd1e Compare January 6, 2024 05:09

newpavlov approved these changes Jan 6, 2024

View reviewed changes

tarcieri merged commit 7febf02 into master Jan 6, 2024
202 checks passed

tarcieri deleted the digest/v0.11.0-pre branch January 6, 2024 06:14

tarcieri added a commit that referenced this pull request Jan 6, 2024

Update MSRV in README.md files

529356d

The new MSRV after #523 is 1.71

tarcieri mentioned this pull request Jan 6, 2024

Update MSRV in README.md files #527

Merged

tarcieri added a commit that referenced this pull request Jan 6, 2024

Update MSRV in README.md files (#527)

1a43b8f

The new MSRV after #523 is 1.71

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump `digest` to v0.11.0-pre.3; MSRV 1.71 #523

Bump `digest` to v0.11.0-pre.3; MSRV 1.71 #523

tarcieri commented Dec 31, 2023

newpavlov left a comment

newpavlov Jan 4, 2024

tarcieri Jan 6, 2024

newpavlov Jan 4, 2024 •

edited

Loading

newpavlov Jan 4, 2024

newpavlov Jan 4, 2024

newpavlov Jan 4, 2024

newpavlov Jan 4, 2024 •

edited

Loading

newpavlov Jan 4, 2024

newpavlov Jan 4, 2024 •

edited

Loading

newpavlov Jan 4, 2024 •

edited

Loading

newpavlov Jan 4, 2024 •

edited

Loading

newpavlov left a comment

	//! // acquire hash digest in the form of Array,
	//! // acquire hash in the form of `hybrid_array::Array`,

	use digest::{array::typenum::U64, bench_update};
	use digest::{typenum::U64, bench_update};

	use digest::{array::typenum::U32, bench_update};
	use digest::{typenum::U32, bench_update};

	use digest::{array::typenum::U128, bench_update};
	use digest::{typenum::U128, bench_update};

	array::typenum::{Unsigned, U28, U32, U48, U64},
	typenum::{Unsigned, U28, U32, U48, U64},

Bump digest to v0.11.0-pre.3; MSRV 1.71 #523

Bump digest to v0.11.0-pre.3; MSRV 1.71 #523

Conversation

tarcieri commented Dec 31, 2023

newpavlov left a comment

Choose a reason for hiding this comment

newpavlov Jan 4, 2024

Choose a reason for hiding this comment

tarcieri Jan 6, 2024

Choose a reason for hiding this comment

newpavlov Jan 4, 2024 • edited Loading

Choose a reason for hiding this comment

newpavlov Jan 4, 2024

Choose a reason for hiding this comment

newpavlov Jan 4, 2024

Choose a reason for hiding this comment

newpavlov Jan 4, 2024

Choose a reason for hiding this comment

newpavlov Jan 4, 2024 • edited Loading

Choose a reason for hiding this comment

newpavlov Jan 4, 2024

Choose a reason for hiding this comment

newpavlov Jan 4, 2024 • edited Loading

Choose a reason for hiding this comment

newpavlov Jan 4, 2024 • edited Loading

Choose a reason for hiding this comment

newpavlov Jan 4, 2024 • edited Loading

Choose a reason for hiding this comment

newpavlov left a comment

Choose a reason for hiding this comment

Bump `digest` to v0.11.0-pre.3; MSRV 1.71 #523

Bump `digest` to v0.11.0-pre.3; MSRV 1.71 #523

newpavlov Jan 4, 2024 •

edited

Loading

newpavlov Jan 4, 2024 •

edited

Loading

newpavlov Jan 4, 2024 •

edited

Loading

newpavlov Jan 4, 2024 •

edited

Loading

newpavlov Jan 4, 2024 •

edited

Loading