[WIP] sha1: add x86 intrinsics support #166
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Closed in favor of #167. |
Contributor
|
Hi, why are you removing runtime feature detection? Very often the code will be built for a generic CPU and will run on one with those extensions (on ARM at least). |
Member
Author
|
I am not removing it, it's just not implemented in the draft PR yet. |
Member
Author
|
And ARM detection works without changes (at least it should). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Ryzen 7 2700X I get up to 2.2 GB/s. For now CPUID detection is absent. I plan to add it based on the approach used in
getrandom.Unfortunately GitHub Actions workers do not have SHA instructions, so we will not be able to properly test this code in CI.
@linkmauve
Can you please check that I haven't broke ARM code?