p521: remove pub from arithmetic module
#961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The relevant types from the `arithmetic` module are available via re-exports, so direct access to the module is unnecessary. It was accidentally exposed in the v0.13.1 release (#958). Exposing the module directly is inconsistent with p192/p224/p256/p384, so this removes it. This is technically a breaking change, but it was added in v0.13.1 which was released a few minutes ago, and will be yanked after this is released.
tarcieri
force-pushed
the
p521/remove-pub-from-arithmetic-module
branch
from
6b291ad
to
2c38039
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The relevant types from the
arithmeticmodule are available via re-exports, so direct access to the module is unnecessary. It was accidentally exposed in the v0.13.1 release (#958).Exposing the module directly is inconsistent with p192/p224/p256/p384, so this removes it. This is technically a breaking change, but it was added in v0.13.1 which was released a few minutes ago, and will be yanked after this is released.