p521: initial ecdsa support with FIPS 186-4 test vectors
#956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial `ecdsa` feature and test vectors to ensure it's working.
Due to P-521's unusual modulus size, we can't use the upstream
`ecdsa::{SigningKey, VerifyingKey}` types (although we are able to use
the generic implementation of ECDSA). The `ecdsa` crate currently
includes bounds for the digest size in several places, including the
RFC6979 implementation, which are incompatible with P-521, which uses a
66-byte serialized scalar size along with SHA-521, which emits a 64-byte
digest.
To work around this, newtypes for `SigningKey` and `VerifyingKey` have
been added. They largely wrap the inner types, but don't use RFC6979 and
instead randomly generate `R` each time signing is performed (using an
on-by-default `getrandom` feature which enables `rand_core::OsRng`).
FIPS 186-4 test vectors adapted from `SigGen.txt` in
`186-4ecdsatestvectors.zip` from:
https://csrc.nist.gov/projects/cryptographic-algorithm-validation-program/digital-signatures
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial
ecdsafeature and test vectors to ensure it's working.Due to P-521's unusual modulus size, we can't use the upstream
ecdsa::{SigningKey, VerifyingKey}types (although we are able to use the generic implementation of ECDSA). Theecdsacrate currently includes bounds for the digest size in several places, including the RFC6979 implementation, which are incompatible with P-521, which uses a 66-byte serialized scalar size along with SHA-521, which emits a 64-byte digest. Fixing that will require breaking changes to theecdsacrate.To work around this, newtypes for
SigningKeyandVerifyingKeyhave been added. They largely wrap the inner types, but don't use RFC6979 and instead randomly generateReach time signing is performed (using an on-by-defaultgetrandomfeature which enablesrand_core::OsRng).FIPS 186-4 test vectors adapted from
SigGen.txtin186-4ecdsatestvectors.zipfrom:https://csrc.nist.gov/projects/cryptographic-algorithm-validation-program/digital-signatures
cc @MasterAwesome