p521: switch to upstream RFC6979-based ECDSA #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
p521/use-upstream-rfc6979-ecdsa
branch
from
175fa79
to
abb2ecb
Compare
Now that RustCrypto/signatures#773 and RustCrypto/signatures#774 have landed it should be possible to use the upstream RFC6979 implementation from the `ecdsa` crate in conjunction with `p521`, which uses a Digest with a 64-byte output, but uses 66-byte field elements.
tarcieri
force-pushed
the
p521/use-upstream-rfc6979-ecdsa
branch
from
abb2ecb
to
0adb2d0
Compare
tarcieri
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that RustCrypto/signatures#773 and RustCrypto/signatures#774 have landed it should be possible to use the upstream RFC6979 implementation from the
ecdsacrate in conjunction withp521, which uses a Digest with a 64-byte output, but uses 66-byte field elements.This required some upstream changes to the
rfc6979crate but is now working: RustCrypto/signatures#781