primefield: crate boilerplate #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now the `primeorder` crate, which contains elliptic curve addition formulas, is also curiously overloaded with some macros for generating field implementations, even though those have nothing in particular to do with the curve formulas. This is largely because `primeorder` was an existing dependency of the other crates, so it was a convenient place to put it. This begins the process of extracting it out into a separate crate. It should also make it easier to perform the `fiat-crypto` upgrade, since we can put the new implementation in `primefield` and leave the existing one in `primeorder` until all crates have been migrated.
tarcieri
added a commit
that referenced
this pull request
Jan 12, 2024
This reverts commit 26be150. Now that we've completed the `elliptic-curve` v0.14.0-pre upgrade, we can restore the fiat-crypto upgrade. This commit takes a slightly different approach and puts the macro implementation for the newest version of `fiat-crypto` into the new `primefield` crate which was added in #1013. The goal will be to update all of the crates and then remove the old macros from `primeorder` entirely.
tarcieri
added a commit
that referenced
this pull request
Jan 12, 2024
This reverts commit 26be150. Now that we've completed the `elliptic-curve` v0.14.0-pre upgrade, we can restore the fiat-crypto upgrade. This commit takes a slightly different approach and puts the macro implementation for the newest version of `fiat-crypto` into the new `primefield` crate which was added in #1013. The goal will be to update all of the crates and then remove the old macros from `primeorder` entirely.
tarcieri
added a commit
that referenced
this pull request
Jan 12, 2024
This reverts commit 26be150. Now that we've completed the `elliptic-curve` v0.14.0-pre upgrade, we can restore the fiat-crypto upgrade. This commit takes a slightly different approach and puts the macro implementation for the newest version of `fiat-crypto` into the new `primefield` crate which was added in #1013. The goal will be to update all of the crates and then remove the old macros from `primeorder` entirely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the
primeordercrate, which contains elliptic curve addition formulas, is also curiously overloaded with some macros for generating field implementations, even though those have nothing in particular to do with the curve formulas.This is largely because
primeorderwas an existing dependency of the other crates, so it was a convenient place to put it.This begins the process of extracting it out into a separate crate. It should also make it easier to perform the
fiat-cryptoupgrade, since we can put the new implementation inprimefieldand leave the existing one inprimeorderuntil all crates have been migrated.