aes: change AES-NI ParBlocksSize back to 8
#519
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes it from 9 back to 8, like it was in `aes` v0.8. Anecdotally we've had some reports of better performance: #515 I also think an odd number of blocks just seems a bit unusual to me, and 8 blocks is what I've typically seen in other implementations.
tarcieri
force-pushed
the
aes/x86-par-blocks-size-8
branch
from
d69a75a to
4b8ca5f
Compare
newpavlov
approved these changes
Jan 7, 2026
Member
|
I am not sure it will help with the performance issue, since IIUC it was caused by failed inlining. But I guess having a power-of-two block size could help with generating more efficient chunking code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes it from 9 back to 8, like it was in
aesv0.8.Anecdotally we've had some reports of better performance: #515
I also think an odd number of blocks just seems a bit unusual to me, and 8 blocks is what I've typically seen in other implementations.