ssh-key: use u64 type for certificate timestamps
#209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
ssh-key/use-u64-type-for-certificate-timestamps
branch
from
921e105
to
7a80c41
Compare
Closes #174 Previously certificates only supported the `i64` range to allow for infallible conversions to/from `SystemTime`. Unfortunately OpenSSH defaults to using `u64::MAX` as the `valid_before` time in order to represent certificate that's valid "forever". The previous restriction meant that `ssh-key` was incapible of parsing such certificates. This commit switches to using a raw `u64` everywhere, and changing conversions to `SystemTime` to return an `Option<SystemTime>` which is `None` if the `u64` value overflows an `i64`.
tarcieri
force-pushed
the
ssh-key/use-u64-type-for-certificate-timestamps
branch
from
7a80c41
to
f8760a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #174
Previously certificates only supported the
i64range to allow for infallible conversions to/fromSystemTime.Unfortunately OpenSSH defaults to using
u64::MAXas thevalid_beforetime in order to represent certificate that's valid "forever". The previous restriction meant thatssh-keywas incapible of parsing such certificates.This commit switches to using a raw
u64everywhere, and changing conversions toSystemTimeto return anOption<SystemTime>which isNoneif theu64value overflows ani64.