ssh-key: fix DsaKeypair::try_sign format error #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The integer components `r` and `s` of the generated signature may be less than 160 bits, which is the exact length required by SSH wire format. This commit fixes #190 by padding the integer components with leading zeros to make them 160 bits long.
tarcieri
approved these changes
Jan 9, 2024
Tests `DSAKeyPair::try_sign` correctly deals with the case where the integer components of the raw DSA signature are not of the expected length.
|
I've added regression test as requested. Please review. Thanks! |
|
Awesome, thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The integer components
randsof the generated signature may be less than 160 bits, which is the exact length required by SSH wire format.This commit fixes #190 by padding the integer components with leading zeros to make them 160 bits long.