Skip to content

frodo-kem: enable cross in CI #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

frodo-kem: enable cross in CI #97

wants to merge 2 commits into from

Conversation

@tarcieri
Copy link
Member

@tarcieri tarcieri commented Jan 21, 2025

Ensures big endian targets are supported by testing on PPC32

@tarcieri
frodo-kem: enable cross in CI
2b20054 
Ensures big endian targets are supported by testing on PPC32
@tarcieri tarcieri requested a review from mikelodder7 January 21, 2025 20:08
@tarcieri
Copy link
Member Author

tarcieri commented Jan 21, 2025

To make this work it can't link against safe-oqs-sys it appears

@mikelodder7
Copy link
Contributor

mikelodder7 commented Jan 21, 2025

That's okay, its just for testing. Perhaps we just conditionally test it against safe-oqs when under specific OS.

@tarcieri
Copy link
Member Author

tarcieri commented Jan 21, 2025

Perhaps it could be gated on a special cfg

@tarcieri tarcieri mentioned this pull request Nov 9, 2025
Closed
tarcieri added a commit that referenced this pull request Nov 10, 2025
@tarcieri
frodo-kem: remove safe-oqs
6f498eb 
Closes: #97 #109 #165

It would be good to be able to retain these equivalence tests, but
they're pretty onerous for anyone trying to develop any KEM.

It also was breaking cross (#97) which can now be enabled for
`frodo-kem`.
@tarcieri tarcieri mentioned this pull request Nov 10, 2025
Merged
tarcieri added a commit that referenced this pull request Nov 10, 2025
@tarcieri
frodo-kem: remove safe-oqs
300e470 
Closes: #97 #109 #165

It would be good to be able to retain these equivalence tests, but
they're pretty onerous for anyone trying to develop any KEM.

It also was breaking cross (#97) which can now be enabled for
`frodo-kem`.
@tarcieri tarcieri closed this Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikelodder7 mikelodder7 Awaiting requested review from mikelodder7

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tarcieri @mikelodder7