Initial implementation of x-wing #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Christiaan676
commented
Sep 17, 2024
Christiaan676
force-pushed
the
x-wing-kem
branch
6 times, most recently
from
9fcea4d
to
9e6b32c
Compare
tarcieri
reviewed
Sep 17, 2024
tarcieri
reviewed
Sep 17, 2024
tarcieri
reviewed
Sep 20, 2024
Christiaan676
force-pushed
the
x-wing-kem
branch
2 times, most recently
from
8221976
to
49855da
Compare
Christiaan676
force-pushed
the
x-wing-kem
branch
from
49855da
to
a4f79f5
Compare
Christiaan676
force-pushed
the
x-wing-kem
branch
from
e455f39
to
4671685
Compare
Christiaan676
commented
Sep 23, 2024
Comment on lines
+65
to
+69
| #[derive(Clone, PartialEq)] | ||
| pub struct EncapsulationKey { | ||
| pk_m: MlKem768EncapsulationKey, | ||
| pk_x: x25519_dalek::PublicKey, | ||
| } |
There was a problem hiding this comment.
For some reason kem::EncapsulationKey<MlKem768Params> does not implement Eq, as far as I can tell implementing Eq should not be a problem as all underling types are u8 arrays or integers.
|
@tarcieri Everything should be done now. Please give it a good review, and let me know if you think I should change anything. Version wise I wonder if we should release it as 0.4 as it follows version 4 of the RFC draft? |
|
Will review soon |
tarcieri
reviewed
Sep 26, 2024
tarcieri
reviewed
Sep 26, 2024
tarcieri
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the X-WING KEM. Following the RFC version 04.
Todo:
Array/HybridArray