Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi, I reworked ports system to prevent having mutable reference to inplace output data I mentioned on #106
Notable change:
InputPort
,OutputPort
andPortType
system is replaced by just types that are the ports.RCell
andRwCell
type used for inplace ports.RCell
prevent is used to prevent writing through input port andRwCell
is just here to be consistent withRCell
inplace
for ports supporting inplace processing and,not_inplace
for ports not supporting inplace processing.Current state: