spirv-builder: check and clippy shortcuts #505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firestar99
commented
Jan 7, 2026
Comment on lines
+679
to
+684
| pub fn check(&mut self) -> Result<CompileResult, SpirvBuilderError> { | ||
| self.run_cargo_cmd("check") | ||
| } | ||
|
|
||
| /// Shortcut for `cargo clippy` | ||
| pub fn clippy(&mut self) -> Result<CompileResult, SpirvBuilderError> { |
Member
Author
There was a problem hiding this comment.
I'm not a huge fan how these are &mut self but build() is only &self. But I also don't want to clone the entire SpirvBuilder just to change that one property, though it probably wouldn't matter performance-wise. Suggestions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nazar-pc ashed in Rust-GPU/cargo-gpu#131 (comment):
So I added these shortcuts, so you can run clippy in your build script, and afterwards still build your shaders without having to clone the
SpirvBuilder.